On Monday, November 21, 2016 03:42:23 PM Paolo Bonzini wrote: > Please rewrite kvm_age_rmapp to use the new mmu_spte_age instead Hi Paolo, While updating kvm_age_rmapp/mmu_spte_age, I noticed an inconsistency in the existing kvm code between the A/D and non-A/D cases. When using A/D bits, kvm_age_hva calls kvm_age_rmapp, which does NOT call kvm_set_pfn_accessed. However, when using EPT without A/D bits, kvm_unmap_rmapp is called, which does internally end up in a call to kvm_set_pfn_accessed. Do you know if this difference is deliberate? If not, should we call kvm_set_pfn_accessed in the A/D case as well, or should we leave that as is? Does it make any difference? Thanks, Junaid -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
