Re: [PATCH kvm-unit-tests v5 13/14] pci: add msi support for 32/64bit address

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 23, 2016 at 11:36:17AM +0100, Andrew Jones wrote:

[...]

> > 
> > IMHO we don't need to check cap_id since cap_id is only used in:
> > 
> >   if (cap_handlers[cap_id])
> >     cap_handlers[cap_id](dev, cap_offset);
> > 
> > As long as we provide correct handlers, we'll naturally skip all
> > unknown cap_ids.
> 
> But cap_handlers only has PCI_CAP_ID_MAX + 1 (21) elements. If you
> read anything greater than 20 for cap_id, then boom.

Hmm, yes, will do. Thanks,

-- peterx
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux