On Tue, Nov 15, 2016 at 11:42:43AM -0500, Peter Xu wrote:
> On Tue, Nov 15, 2016 at 09:58:40AM +0100, Andrew Jones wrote:
>
> [...]
>
> > > @@ -25,6 +25,8 @@ struct pci_dev {
> > >
> > > void pci_dev_init(struct pci_dev *dev, pcidevaddr_t bdf);
> > > void pci_scan_bars(struct pci_dev *dev);
> > > +void pci_cmd_set_clr(struct pci_dev *dev, uint16_t set, uint16_t clr);
> > > +void pci_enable_defaults(struct pci_dev *dev);
> >
> > Don't forget the [pointless] externs on these functions for this patch,
> > and the ones that introduced the functions above.
>
> Adding all of them missing for pci.h. Actually I see there's still one
> missing:
>
> int pci_testdev(void);
>
> But I won't touch it since that's irrelevant to this series (and I am
> always okay /wo "extern" :).
"fix" that one too please.
thanks,
drew
>
> [...]
>
> > Reviewed-by: Andrew Jones <drjones@xxxxxxxxxx>
>
> Adding this too. Thanks,
>
> -- peterx
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
