Re: [PATCH v3 09/13] pci: provide pci_enable_defaults()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 15, 2016 at 09:58:40AM +0100, Andrew Jones wrote:

[...]

> > @@ -25,6 +25,8 @@ struct pci_dev {
> >  
> >  void pci_dev_init(struct pci_dev *dev, pcidevaddr_t bdf);
> >  void pci_scan_bars(struct pci_dev *dev);
> > +void pci_cmd_set_clr(struct pci_dev *dev, uint16_t set, uint16_t clr);
> > +void pci_enable_defaults(struct pci_dev *dev);
> 
> Don't forget the [pointless] externs on these functions for this patch,
> and the ones that introduced the functions above.

Adding all of them missing for pci.h. Actually I see there's still one
missing:

  int pci_testdev(void);

But I won't touch it since that's irrelevant to this series (and I am
always okay /wo "extern" :).

[...]

> Reviewed-by: Andrew Jones <drjones@xxxxxxxxxx>

Adding this too. Thanks,

-- peterx
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux