Re: [kvm-unit-tests PATCH 12/14] x86: intel-iommu: add dmar test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 19, 2016 at 10:33:53PM +0200, Radim Krčmář wrote:
> 2016-10-14 20:40+0800, Peter Xu:

[...]

> >  int main(int argc, char *argv[])
> >  {
> > +	int ret;
> > +	pci_edu_dev_t dev;
> > +
> >  	setup_vm();
> >  	smp_init();
> >  	setup_idt();
> > @@ -37,5 +76,18 @@ int main(int argc, char *argv[])
> >  	vtd_enable_ir();
> >  	report("IR enablement", vtd_status() & VTD_GCMD_IR);
> >  
> > +	report("DMAR support 39 bits address width",
> > +	       vtd_cap() & VTD_CAP_SAGAW);
> > +
> > +	report("DMAR support huge pages", vtd_cap() & VTD_CAP_SLLPS);
> > +
> > +	ret = edu_init(&dev);
> > +	if (ret) {
> > +		printf("Please specify \"-device edu\" to test IOMMU.\n");
> > +		return -1;
> 
> The test did something before this point, so we should print a summary
> before exiting.  Probably the best thing would be to report_skip() the
> following tests, because the device needed for them couldn't be found.

Sounds reasonable. Will fix. Thanks!

-- peterx
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux