On Wed, Oct 19, 2016 at 10:23:55PM +0200, Radim Krčmář wrote: > 2016-10-14 20:40+0800, Peter Xu: > > Signed-off-by: Peter Xu <peterx@xxxxxxxxxx> > > --- > > lib/x86/smp.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/lib/x86/smp.c b/lib/x86/smp.c > > index 1eb49f2..bb74087 100644 > > --- a/lib/x86/smp.c > > +++ b/lib/x86/smp.c > > @@ -111,8 +111,13 @@ void on_cpu_async(int cpu, void (*function)(void *data), void *data) > > void smp_init(void) > > { > > int i; > > + bool smp_inited = false; > > Missing "static". Oops. Will fix. > > The first two patches are just for sanity and not needed in the series? Yes actually these are not exactly related to vt-d, but good to have along the way, just like setup_idt() does. E.g., if one calls the new vtd_init() in future tests to init VT-d environment, he needs to make sure himself not to call the smp/vm init function twice (these things are required by VT-d and inited in vtd_init() already). These two patches will make sure it works in all cases. Thanks! -- peterx -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html