On Mon, Jun 13, 2016 at 04:03:53PM +0200, Paolo Bonzini wrote:
>
>
> On 13/06/2016 15:57, Andrew Jones wrote:
> >> >
> >> > There is no reason to include asm/barrier.h here. Please remove this
> >> > indirect inclusion.
> > lib/asm-generic/io.h has barrier use. Without including it here,
> > then all includers of lib/asm-generic/io.h must include
> > asm/barrier.h first, even if they're unaware of the barrier use.
>
> Are the barriers really necessary? I.e. why do we need
> __raw_{read,write}* vs just {read,write}*.
We could drop the wrappers, and require unit tests to use barriers
explicitly, when needed. I'm OK with that, because I think I mostly
forget that we have them in the wrappers and use them explicitly
anyway... I'll need to double check all the uses though.
Thanks,
drew
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
