On Mon, Jun 13, 2016 at 03:35:43PM +0200, Paolo Bonzini wrote: > > > On 10/06/2016 08:37, Alexander Gordeev wrote: > > diff --git a/lib/asm-generic/io.h b/lib/asm-generic/io.h > > index 842868ab9d58..91a2d7995d3d 100644 > > --- a/lib/asm-generic/io.h > > +++ b/lib/asm-generic/io.h > > @@ -11,6 +11,7 @@ > > */ > > #include "libcflat.h" > > #include "asm/page.h" > > +#include "asm/barrier.h" > > There is no reason to include asm/barrier.h here. Please remove this > indirect inclusion. lib/asm-generic/io.h has barrier use. Without including it here, then all includers of lib/asm-generic/io.h must include asm/barrier.h first, even if they're unaware of the barrier use. drew -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html