On 5/23/2016 11:21 AM, Eric Auger wrote: >> + acpi_ret = acpi_evaluate_integer(handle, "_RST", NULL, &val); >> > + if (ACPI_FAILURE(acpi_ret)) >> > + return -EINVAL; > Can't you return something more explicit here? The error code will be > visible to the userspace. Difficult for him to understand the cause of > the failure in that case. I can also add a reset failed message to both DT and ACPI reset calls. Will that work? -- Sinan Kaya Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html