On 21/03/2016 12:56, Han, Huaitong wrote: >> > + entry->ecx &= kvm_supported_word16_x86_features; >> > + cpuid_mask(&entry->ecx, 16); > cpuid_mask(&entry->ecx, CPUID_7_ECX), CPUID_7_ECX is better than 16? If the name of the variable is kvm_supported_word16_x86_features, it is not necessarily better. If we rename the variables with names like kvm_supported_cpuid_7_ecx_x86_features, then of course we use CPUID_7_ECX as well. Paolo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
