Re: [PATCH v3] powerpc: Add tests for sPAPR h-calls

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 02/03/2016 11:56, Thomas Huth wrote:
> > > +
> > > +	asm volatile (" sc 1 " : "+r"(r3), "=r"(r4) : "r"(r3));
> > 
> > as you use "+r" with r3 in the output operands field, I think you don't
> > have to declare it in the input operands field.
> 
> Ah, ok, ... gcc inline assembly is always confusing...
> Paolo, Andrew, shall I sent a new version for fixing this nit, or is it
> ok to keep it in the current, slightly redundant shape?

I guess the current one is fine because of the asm register in the
declarations.

The "really correct" one would use "=r" in the r3 output and "0" in the
r3 input, I think.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux