Re: [kvm-unit-tests PATCH v2] powerpc: Add tests for sPAPR h-calls

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01.03.2016 13:27, Andrew Jones wrote:
> On Tue, Mar 01, 2016 at 01:06:11PM +0100, Thomas Huth wrote:
>> On 01.03.2016 12:51, Laurent Vivier wrote:
>>>
>>> On 01/03/2016 11:08, Thomas Huth wrote:
>>>> Introduce a test for sPAPR hypercalls, starting with the
>>>> three hypercalls H_SET_SPRG0, H_PAGE_INIT and H_RANDOM.
>>>>
>>>> Signed-off-by: Thomas Huth <thuth@xxxxxxxxxx>
...
>>> Is it possible to have a message for the H_RANDOM test, something like
>>> "not supported"?
>>
>> I initially had something like that in my code, but the output like
>>
>>  PASS: hypercall: h_random: not supported
>>
>> then also looks somewhat strange ...
>>
>> Is there already a common sense how to (not) report missing and thus
>> untestable features in kvm-unit-tests? Something like
>>
>>  SKIP: hypercall: h_random: not supported
>>
>> would be posh, I think...
> 
> We have XFAIL (instead of SKIP). So you could maybe do something like
> 
>  report_xfail(fmt, !is_supported, test_passed, ...)

Ah, that looks fine, thanks for the hint, I'll change my patch to use it!

 Thomas
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux