On Tue, Mar 01, 2016 at 01:06:11PM +0100, Thomas Huth wrote: > On 01.03.2016 12:51, Laurent Vivier wrote: > > > > > > On 01/03/2016 11:08, Thomas Huth wrote: > >> Introduce a test for sPAPR hypercalls, starting with the > >> three hypercalls H_SET_SPRG0, H_PAGE_INIT and H_RANDOM. > >> > >> Signed-off-by: Thomas Huth <thuth@xxxxxxxxxx> > > > > A xouple of stupid questions: > > > > Is that normal they are all failing? > > > > FAIL: hypercall: h_set_sprg0: sprg0 = 0xcafebabedeadbeef > > FAIL: hypercall: h_set_sprg0: sprg0 = 0xaaaaaaaa55555555 > > FAIL: hypercall: h_set_sprg0: sprg0 = 0x0 > > FAIL: hypercall: h_page_init: h_zero_page > > FAIL: hypercall: h_page_init: h_copy_page > > FAIL: hypercall: h_page_init: h_copy_page+h_zero_page > > FAIL: hypercall: h_page_init: h_zero_page unaligned dst > > FAIL: hypercall: h_page_init: h_copy_page unaligned src > > > > SUMMARY: 8 tests, 8 unexpected failures > > Did you use the very latest git version of QEMU? ... these two > hypercalls have just been added recently, so the tests fail if your QEMU > does not support them yet. > > > Is it possible to have a message for the H_RANDOM test, something like > > "not supported"? > > I initially had something like that in my code, but the output like > > PASS: hypercall: h_random: not supported > > then also looks somewhat strange ... > > Is there already a common sense how to (not) report missing and thus > untestable features in kvm-unit-tests? Something like > > SKIP: hypercall: h_random: not supported > > would be posh, I think... We have XFAIL (instead of SKIP). So you could maybe do something like report_xfail(fmt, !is_supported, test_passed, ...) Thanks, drew -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
