On 25/01/2016 16:20, Radim Krcmár wrote:
> 2016-01-25 13:25+0100, Paolo Bonzini:
>> On 22/01/2016 15:01, Radim Krcmár wrote:
>>>> for (i = 0; i <= mod; i++) {
>>>> idx = find_next_bit(bitmap, bitmap_size, idx + 1);
>>>> BUG_ON(idx == bitmap_size);
>>>> }
>>
>> WARN_ON, not BUG_ON.
>
> Callers don't check the return value for an error, because every error
> is a BUG now. I think that we should check if we return bitmap_size.
> (Current paths could dereference NULL or throw unrelated warnings.)
You can probably just return a random number (e.g. zero or
find_first_bit) if the bug is hit. But really, the bug is easy enough
to verify that BUG_ON might even be okay...
Paolo
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
