> -----Original Message----- > From: Radim Krčmář [mailto:rkrcmar@xxxxxxxxxx] > Sent: Friday, January 22, 2016 3:50 AM > To: Wu, Feng <feng.wu@xxxxxxxxx> > Cc: pbonzini@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > kvm@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v3 2/4] KVM: x86: Use vector-hashing to deliver lowest- > priority interrupts > > 2016-01-20 09:42+0800, Feng Wu: > > Use vector-hashing to deliver lowest-priority interrupts, As an > > example, modern Intel CPUs in server platform use this method to > > handle lowest-priority interrupts. > > > > Signed-off-by: Feng Wu <feng.wu@xxxxxxxxx> > > --- > > Functionality looks good, so I had a lot of stylistic comments, sorry :) Any comments are welcome! Thank you! :) > > > + const unsigned long *bitmap, u32 bitmap_size) > > +{ > > + u32 mod; > > + int i, idx = 0; > > + > > + mod = vector % dest_vcpus; > > + > > + for (i = 0; i <= mod; i++) { > > + idx = find_next_bit(bitmap, bitmap_size, idx) + 1; > > I'd remove this "+ 1". Current users don't check for errors and always > do "- 1". The new error value could be 'idx = bitmap_size', with u32 as > return type. > Does the following code look good to you: u32 mod; int i, idx = -1; mod = vector % dest_vcpus; for (i = 0; i <= mod; i++) { idx = find_next_bit(bitmap, bitmap_size, idx + 1); BUG_ON(idx == bitmap_size); } return idx; Thanks, Feng -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
