Re: [kvm-unit-tests PATCH v2 05/10] x86: move x86/pci to the common lib

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2016-01-18 14:59+0100, Andrew Jones:
> On Fri, Jan 15, 2016 at 10:57:09PM +0100, Radim Krčmář wrote:
>> 2016-01-15 17:51+0100, Andrew Jones:
>>> +++ b/lib/x86/asm/pci.h
>>> +static inline uint32_t pci_config_read(pcidevaddr_t dev, uint8_t reg)
>>> +{
>>> +    uint32_t index = reg | (dev << 8) | (0x1 << 31);
>>> +    outl(index, 0xCF8);
>>> +    return inl(0xCFC);
>> 
>> Hm, why can't this be generalized with [1/10]?
> 
> 0xcf8 and 0xcfc are special x86 ports. Other architectures need to do
> other things.

Ok, thanks.  If the port space is not standardized, we have even less
reasons to share in*/out*.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux