2016-01-18 14:55+0100, Andrew Jones: > On Fri, Jan 15, 2016 at 10:39:23PM +0100, Radim Krčmář wrote: >> 2016-01-15 17:51+0100, Andrew Jones: >>> diff --git a/lib/x86/vm.h b/lib/x86/vm.h >>> +#define virt_to_phys virt_to_phys >>> +#define phys_to_virt phys_to_virt >> >> Nitpick: if we always define all (both) functions, using two guarding >> #defines is pure waste. lib/asm-generic/io.h even has both functions >> under one #ifndef virt_to_phys. (It would be better with a sensible >> name instead of virt_to_phys and if it was in lib/asm-generic/vm.h. :]) > > This is just a consistency with Linux thing again. If you want to drop > the #include "asm-generic/io.h" from lib/x86/asm/io.h, then these can > go away too. I wouldn't drop asm-generic/io.h, but #define phys_to_virt phys_to_virt because it's not consistent with Linux nor itself. This nitpick wasn't the reason I didn't review, so if you don't want to drop [1/10], Reviewed-by: Radim Krčmář <rkrcmar@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
