Hello Andre! I haven't heard from you on any of my questions. But, nevertheless, i would like to inform you (and other interested people) that i'm leaving on vacation, and will be back 2 weeks later. Just in case if someone writes me something and i don't reply. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia > -----Original Message----- > From: kvm-owner@xxxxxxxxxxxxxxx [mailto:kvm-owner@xxxxxxxxxxxxxxx] On Behalf Of Pavel Fedin > Sent: Monday, September 07, 2015 10:57 AM > To: 'Andre Przywara' > Cc: kvmarm@xxxxxxxxxxxxxxxxxxxxx; kvm@xxxxxxxxxxxxxxx; 'Marc Zyngier'; 'Peter Maydell' > Subject: RE: [PATCH v3 2/5] KVM: arm64: Implement vGICv3 distributor and redistributor access > from userspace > > Hello! > > > > --- a/virt/kvm/arm/vgic.c > > > +++ b/virt/kvm/arm/vgic.c > > > @@ -2468,6 +2468,7 @@ int vgic_attr_regs_access(struct kvm_device *dev, > > > * access. For 64-bit registers we have to split up the operation. > > > */ > > > mmio->len = sizeof(u32); > > > + mmio->private = vcpu; /* For redistributor handlers */ > > > > I guess this can be moved into the caller and then you can drop the vcpu > > parameter and use private here instead, no? > > No because 'vcpu' is not a parameter. It is figured out in the middle of the function, under > dev->kvm->lock mutex, out of 'cpuid' index. > > Kind regards, > Pavel Fedin > Expert Engineer > Samsung Electronics Research center Russia > > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html