On 21/08/2015 06:50, Xiao Guangrong wrote: > > +static void set_clear_2nd_exec_ctrl(u32 ctrls, bool set) > +{ > + u32 exec_ctrl = vmcs_read32(SECONDARY_VM_EXEC_CONTROL); > + > + if (set) > + exec_ctrl |= ctrls; > + else > + exec_ctrl &= ~ctrls; > + > + vmcs_write32(SECONDARY_VM_EXEC_CONTROL, exec_ctrl); > +} The second argument is always true. Do you have any plans for it? Should we instead add functions like vmcs_or32 and vmcs_clear32? Paolo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html