Re: [PATCH v7 2/3] KVM: dynamic halt-polling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/6/15 10:32 PM, Paolo Bonzini wrote:

On 05/09/2015 00:38, Wanpeng Li wrote:
@@ -1940,11 +1975,16 @@ void kvm_vcpu_block(struct kvm_vcpu *vcpu)
                * arrives.
                */
               if (kvm_vcpu_check_block(vcpu) < 0) {
+                polled = true;
                   ++vcpu->stat.halt_successful_poll;
-                goto out;
+                break;
               }
               cur = ktime_get();
           } while (single_task_running() && ktime_before(cur, stop));
+
+        poll_ns = ktime_to_ns(cur) - ktime_to_ns(start);
+        if (polled)
+            goto out;

Please move poll_ns caculation under if() when you applied, as I
explained in reply to v6.
You can do much more than just that, the patch reduces to this:


Cool, many thanks for your help, Paolo! :)

Regards,
Wanpeng Li
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux