Hello! > Mmmh, not sure about this, but I guess u64 would be more precise here? > With the Rt2 handling below we rely on this being 64 bits anyway. But I > guess that breaks with assigning vcpu_reg later and since this is arm64 > only, long is always 64 bits? It is because ' params.val = &val'. And params.val is u_long * because of: 'params.val = vcpu_reg(vcpu, Rt)'. vcpu_reg() is declared as unsigned long * : http://lxr.free-electrons.com/source/arch/arm64/include/asm/kvm_emulate.h#L102 Initially i declared params.val as u64 *, but got warning in 'params.val = vcpu_reg(vcpu, Rt)'. So i decided to change it to u_long * instead of having casts here and there. Do you like casts? Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
