On Wed, Jul 29, 2015 at 2:41 AM, Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote: > > > On 29/07/2015 11:40, Peter Zijlstra wrote: >> > Well, people have complained about it because it's KERN_ERR. Do you >> > think it is okay to downgrade this (perhaps not even just on VMs) to info? >> >> Ah, do people really have nothing better to do? ;-) Seems like a petty >> complaint. >> >> Sure, it seems our check_hw_exists() does the same thing: >> >> printk("%sFailed to access perfctr msr (MSR %x is %Lx)\n", >> boot_cpu_has(X86_FEATURE_HYPERVISOR) ? KERN_INFO : KERN_ERR, >> reg, val_new); >> >> so ERR for real hardware, INFO for hypervisor thingies. > > Great, I'll send a patch then! > With that patch applied, would anything actually go wrong if we did something like this: https://git.kernel.org/cgit/linux/kernel/git/luto/linux.git/commit/?h=x86/pv_msr If not, I'll send it out and we can see if anything awful shakes out. If the sky doesn't fall, then maybe KVM_GUEST can drop its PARAVIRT dependency. --Andy -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html