Hi, On 13/07/15 15:24, Eric Auger wrote: > On 07/13/2015 03:32 PM, Pavel Fedin wrote: >> Hello! >> >>> I think I prefer the flag. Offhand it sounds easier to add support for >>> it to non-ARM architectures, compared to KVM_IRQ_ROUTING_EXTENDED_MSI. >> >> Actually i also voted for flag, because it is already introduced in (2), and i'm not a fan of >> adding new definitions where we can reuse existing ones. IMHO using flag would make an API more >> consistent. > > OK I will respin with user space flag. > > Andre, what about the kernel routing entry struct. You wanted me to get > rid of KVM_IRQ_ROUTING_EXTENDED_MSI there too. Will you be able to > manage a usespace wrong setting if the type is not set? I am about to see how this all fits together, but I don't expect any serious problems, at least on the kvmtool side. Instead of setting a different type I just set the flag and guard that by the capability: should be not an issue. Cheers, Andre. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
