13/07/2015 15:16, Eric Auger wrote: >> > >> > + irqfd->consumer.token = (void *)irqfd->eventfd; >> > + kvm_arch_irq_consumer_init(&irqfd->consumer); > what if the architecture does not implement kvm_arch_irq_consumer_init? > > Also you are using here this single function kvm_arch_irq_consumer_init > to do some irq bypass manager settings + attaching your > irqfd->arch_update cb which does not really relate to IRQ bypass > manager. I think I preferred the approach where start/top/add/del were > exposed separately ([RFC v2 5/6] KVM: introduce kvm_arch functions for > IRQ bypass). > > Why not adding another kvm_arch_irq_routing_update then, not necessarily > linked to irq bypass manager. Yes, I also preferred the dummy kvm_arch_* functions to this approach with an init function. You'd have to add dummy init functions anyway for non-ARM, non-x86 architectures. Paolo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
