On Mon, 27 Apr 2015 14:19:13 +0200 Cornelia Huck <cornelia.huck@xxxxxxxxxx> wrote: > > > >> Would it make sense to do the cast here.... > > > > > > > > cpu_model_get/set() is used to handle both attributes, > > > > KVM_S390_VM_CPU_MACHINE and KVM_S390_VM_CPU_PROCESSOR. > > > > Both require a different type in the signature, (S390ProcessorProps*) > > > > and (S390MachineProps*). Adding both as parameters seems to be odd > > > > and would require additionally logic in the function. > > > > Thus I think doing the cast outside is just the right thing to do. > > > > > > So what about a void pointer then as parameter? > > > I prefer a pointer for qemu process memory over uint64_t as part of the > > > function interface. This makes it somewhat clearer that this is an > > > address within QEMU. Both ways will certainly work, though. > > > > The interface calls are: > > > > int kvm_s390_get_machine_props(KVMState *s, S390MachineProps *prop) > > int kvm_s390_get_processor_props(S390ProcessorProps *prop) > > > > cpu_model_get/set() are just static helpers. > > So this makes them internal calls... > > > > > > > > > Conny, I guess you will pick up the patches. Any preference? > > ...and I'd prefer using a void pointer for them. Ok, I will make void pointers then to emphasize their address characteristics. Michael -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
