2015-03-14 18:00-0600, James Sullivan: > * DM=1, RH=0 : Logical destination mode without redirection. Interrupt > is delivered to all LAPICs in the logical group > specified by the IRQ's destination map and delivery > mode. Your previous patch changed this case to physical. (Mention in the cover letter what unmerged patches you depend on.) > Let me know your thoughts. Please document changes in their commits; the information in cover letter is virtually lost (git sucks at handling series). If you feel like you would be repeating yourself, or have nothing to say at all, it is a signal for rethinking the division. The "logical change" of each patch doesn't need to be minimal -- we seek the perfect balance between the number of patches, hunks in them, and their complexity. I don't see a need for more than two patches here: 1) introduce and initialize msi_redir_hint [1-5,9/9] 2) use msi_redir_hint for lowest-priority delivery [6-8/9] I think it would be better to rename the kvm_is_dm_lowest_prio() helper, check for msi_redir_hint there, move it to a header, and use in kvm_irq_delivery_to_apic_fast() too. Thanks. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
