Re: Reason for extra struct kvm_run parameter in MMIO handling?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Radim, Paolo,

On 09/02/15 16:26, Paolo Bonzini wrote:
> On 09/02/2015 17:21, Radim Krčmář wrote:
>>> So is that just legacy code still lingering around from the dawn of time
>>> and nobody dared to rework this or is there a particular reason for
>>> doing so?
>>
>> Probably laziness in 9a2bb7f486dc639a1cf2ad803bf2227f0dc0809d.
> 
> Or microoptimization.  Laziness is more likely though.
> 
>>> I am asking because I lack the kvm_run pointer in the MMIO handler, so I
>>> just use vcpu->run and I wonder if there are potential issues in doing so.
>>
>> We do it at few places already, so there, hopefully, is no problem.
> 
> Yup.  Thanks Radim for answering!

thanks for the answer and the confirmation!
Looks like I don't dare to write a patch for that ;-)

Cheers,
Andre.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux