Re: Reason for extra struct kvm_run parameter in MMIO handling?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2015-02-06 17:30+0000, Andre Przywara:
> As kvm_run is a member of kvm_vcpu, the vcpu alone should be sufficient,
> right?

Yes.

> Also I see the very top of the call chain is effectively:
> kvm_arch_vcpu_ioctl_run(vcpu, vcpu->run);

:(

> So is that just legacy code still lingering around from the dawn of time
> and nobody dared to rework this or is there a particular reason for
> doing so?

Probably laziness in 9a2bb7f486dc639a1cf2ad803bf2227f0dc0809d.

> I am asking because I lack the kvm_run pointer in the MMIO handler, so I
> just use vcpu->run and I wonder if there are potential issues in doing so.

We do it at few places already, so there, hopefully, is no problem.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux