On Tue, Dec 9, 2014 at 12:37 PM, Julien Grall <julien.grall@xxxxxxxxxx> wrote: > On 09/12/14 20:22, Luis R. Rodriguez wrote: >> On Tue, Dec 9, 2014 at 1:06 AM, Julien Grall <julien.grall@xxxxxxxxxx> wrote: >>> Hello Luis, >>> >>> On 08/12/2014 23:05, Luis R. Rodriguez wrote: >>>> >>>> diff --git a/kernel/configs/xen.config b/kernel/configs/xen.config >>>> new file mode 100644 >>>> index 0000000..0d0eb6d >>>> --- /dev/null >>>> +++ b/kernel/configs/xen.config >>>> +CONFIG_XEN_MCE_LOG=y >>> >>> >>> MCE is x86 specific. >> >> That's what I thought too but its available for arm64, so should we >> fix that Kconfig to depend on x86? > > Are you sure? On the Linus's repo I have: > > config XEN_MCE_LOG > bool "Xen platform mcelog" > depends on XEN_DOM0 && X86_64 && X86_MCE > > Anyway, the MCE interface in the hypervisor is implemented in arch/x86 > not in common code. OK I'll move to x86. >>>> +CONFIG_XEN_HAVE_PVMMU=y >>> >>> >>> We don't have PVMMU support on ARM. Shouldn't you move this config in >>> architecture specific code? >> >> If you are sure then yes. > > I'm 100% sure. MMU is handled by the hardware on ARM. > > Thinking a bit more about this option. CONFIG_XEN_HAVE_PVMMU can't be > selected by the user. It's automatically added per platform (for > instance see arch/x86/xen/Kconfig). > > So maybe it should not even appear in the one of the fragment configs? And I'll remove this one. Luis -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
