2014-12-10 00:18+0300, Eugene Korenevsky: > +static bool vmx_load_msr_entry_verify(struct kvm_vcpu *vcpu, > + struct vmx_msr_entry *e) [...] > + /* x2APIC MSR accesses are not allowed */ > + if (apic_x2apic_mode(vcpu->arch.apic) && (e->index >> 24) == 0x800) > + return false; GCC doesn't warn that "((u32)e->index >> 24) == 0x800" is always false? I think SDM says '(e->index >> 8) == 0x8'. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html