Re: Another Obsolete Fix me in trace.h?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 24/11/2014 05:36, nick wrote:
> Greetings Again Gleb and others,
> I am assuming in the code I am pasting below the fix me is obsolete now and I can remove it. :)
> Cheers Nick
> TP_printk("%s (0x%x)",
>                   __print_symbolic(__entry->exception, kvm_trace_sym_exc),
>                    /* FIXME: don't print error_code if not present */
>                   __entry->has_error ? __entry->error_code : 0)
> );
> 

No, it's not obsolete, the idea is to print only

   %s

instead of

   %s (0x%x)

if __entry->has_error is false.  I don't know the trace API well enough
to know if that is possible.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux