On 24/11/2014 05:25, Nicholas Krause wrote:
> Remove fixme comments about needing fault addresses to be returned. These
> are propaagated from walk_addr_generic to gva_to_gpa and from there to
> ops->read_std and ops->write_std.
>
> Signed-off-by: Nicholas Krause <xerofoify@xxxxxxxxx>
> ---
> arch/x86/kvm/emulate.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
> index 9f8a2fa..16b5d52 100644
> --- a/arch/x86/kvm/emulate.c
> +++ b/arch/x86/kvm/emulate.c
> @@ -2751,7 +2751,6 @@ static int task_switch_32(struct x86_emulate_ctxt *ctxt,
> ret = ops->read_std(ctxt, old_tss_base, &tss_seg, sizeof tss_seg,
> &ctxt->exception);
> if (ret != X86EMUL_CONTINUE)
> - /* FIXME: need to provide precise fault address */
> return ret;
>
> save_state_to_tss32(ctxt, &tss_seg);
> @@ -2760,13 +2759,11 @@ static int task_switch_32(struct x86_emulate_ctxt *ctxt,
> ret = ops->write_std(ctxt, old_tss_base + eip_offset, &tss_seg.eip,
> ldt_sel_offset - eip_offset, &ctxt->exception);
> if (ret != X86EMUL_CONTINUE)
> - /* FIXME: need to provide precise fault address */
> return ret;
>
> ret = ops->read_std(ctxt, new_tss_base, &tss_seg, sizeof tss_seg,
> &ctxt->exception);
> if (ret != X86EMUL_CONTINUE)
> - /* FIXME: need to provide precise fault address */
> return ret;
>
> if (old_tss_sel != 0xffff) {
> @@ -2777,7 +2774,6 @@ static int task_switch_32(struct x86_emulate_ctxt *ctxt,
> sizeof tss_seg.prev_task_link,
> &ctxt->exception);
> if (ret != X86EMUL_CONTINUE)
> - /* FIXME: need to provide precise fault address */
> return ret;
> }
>
>
Thanks, this patch has been applied already.
Paolo
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
