Il 07/10/2014 11:15, Nadav Amit ha scritto: > > On Oct 6, 2014, at 11:50 PM, Radim Krčmář <rkrcmar@xxxxxxxxxx> wrote: > >> 2014-10-03 01:10+0300, Nadav Amit: >>> Once an instruction crosses a page boundary, the size read from the second page >>> disregards the common case that part of the operand resides on the first page. >>> As a result, fetch of long insturctions may fail, and thereby cause the >>> decoding to fail as well. >>> >>> Signed-off-by: Nadav Amit <namit@xxxxxxxxxxxxxxxxx> >>> --- >> >> Good catch, was it thanks to an exhaustive test-suite? >> >> Reviewed-by: Radim Krčmář <rkrcmar@xxxxxxxxxx> > > It was catcher in a test-environment. However, I keep wondering how it did not happen in real guest OS. > I think it is due to pure luck, so I recommend to put it in -stable. The shorter the immediate, the more you need an unlucky alignment for this to happen. For example, say you have 10 byte instruction with 2 opcode bytes and one qword immediate. 1) Instruction at 0x1ffd, __do_insn_fetch_bytes is requested 8 bytes instead of 7, but it accepts up to 15 - 3 = 12 bytes and everything works. 2) Instruction at 0x1ff7, __do_insn_fetch_bytes is requested 8 bytes instead of 1. It accepts up to 15 - 9 = 6 bytes and fails. Most emulated instructions have a 4-byte immediate or no immediate at all. Fixes: 5cfc7e0f5e5e1adf998df94f8e36edaf5d30d38e Paolo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
