Re: [PATCH 3/5] KVM: x86: Decoding guest instructions which cross page boundary may fail

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Oct 6, 2014, at 11:50 PM, Radim Krčmář <rkrcmar@xxxxxxxxxx> wrote:

> 2014-10-03 01:10+0300, Nadav Amit:
>> Once an instruction crosses a page boundary, the size read from the second page
>> disregards the common case that part of the operand resides on the first page.
>> As a result, fetch of long insturctions may fail, and thereby cause the
>> decoding to fail as well.
>> 
>> Signed-off-by: Nadav Amit <namit@xxxxxxxxxxxxxxxxx>
>> ---
> 
> Good catch, was it thanks to an exhaustive test-suite?
> 
> Reviewed-by: Radim Krčmář <rkrcmar@xxxxxxxxxx>

It was catcher in a test-environment. However, I keep wondering how it did not happen in real guest OS.
I think it is due to pure luck, so I recommend to put it in -stable.

Nadav--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux