2014-09-30 20:49+0300, Nadav Amit: > Even after the recent fix, the assertion on paging_tmpl.h is triggered. > Apparently, the assertion wants to check that the PAE is always set on > long-mode, but does it in incorrect way. Note that the assertion is not > enabled unless the code is debugged by defining MMU_DEBUG. I think it was only supposed to be used together with (vcpu->cr3 & CR3_NONPAE_RESERVED_BITS) == 0) to checked if CR3 does not contain ones where it shouldn't when in short mode without PAE, because SDM says the lower 12 bits of the address are assumed to be 0. and when we (incorrectly) removed the second part of condition, it started to bug. I'd remove the new assert, it does not nothing useful, but is correct Reviewed-by: Radim Krčmář <rkrcmar@xxxxxxxxxx> > - ASSERT(!is_long_mode(vcpu) && is_pae(vcpu)); > + ASSERT(!is_long_mode(vcpu) || is_pae(vcpu)); -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
