2014-09-30 20:49+0300, Nadav Amit: > Determining flat mode according to cid_mask is wrong, since currently KVM > supports zero clusters in x2apic mode. Use ldr_bits instead. No, it is in else branch of 'if (apic_x2apic_mode(apic))', so it works as intended now, and ldr_bits == 8 is always true. > Since we recalculate the apic map whenever the DFR is changed, the bug appears > to have no effect, and perhaps the entire check can be removed. It could, for the check is just an optimization. (This whole code deserves a rewrite though ...) -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html