Re: [PATCH 2/3] Fix CPU hotplug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 04, 2009 at 03:24:59PM +0200, Avi Kivity wrote:
> Gleb Natapov wrote:
>>>>   struct pci_status {
>>>> @@ -603,10 +603,12 @@ static uint32_t gpe_readb(void *opaque, uint32_t addr)
>>>>      struct gpe_regs *g = opaque;
>>>>      switch (addr) {
>>>>          case PROC_BASE:
>>>> -            val = g->up;
>>>> -            break;
>>>>          case PROC_BASE + 1:
>>>> -            val = g->down;
>>>> +            val = gpe_read_val(g->cpus_sts, addr);
>>>> +            break;
>>>> +        case PROC_BASE + 2:
>>>> +        case PROC_BASE + 3:
>>>> +            val = gpe_read_val(g->bios_cpus_sts, addr);
>>>>              break;
>>>>         
>>> Why can't the bios maintain bios_cpu_sts in RAM?
>>>
>>>     
>> It can, just need to find a place for it. Currently our AML does not use
>> RAM at all.
>
> OperationRegion(..., SystemMemory, ...) should work.  It's better to  
> avoid introducing unnecessary virtual hardware.
>
But what address to chose. It needs to be reserved in e820 map and S3
resume should not touch it.

--
			Gleb.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux