Re: [Qemu-devel] [PATCH v2 6/8] qemu:virtio-net: Enable filtering based on MAC, promisc, broadcast and allmulti

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Blue Swirl wrote:
On 2/3/09, Alex Williamson <alex.williamson@xxxxxx> wrote:
Make use of the new RX_MODE control virtqueue class by dropping
 packets the guest doesn't want to see.

 Signed-off-by: Alex Williamson <alex.williamson@xxxxxx>

 +    static uint8_t bcast[] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff};

'const'?

It may be good practice but practically speaking, I don't think it will generate different code. The only thing that uses bcast is memcmp() which should be a builtin. Since bcast doesn't otherwise escape the function, it's an obvious candidate for optimization. I think the compiler already has enough information that const doesn't tell it anything more.

Regards,

Anthony Liguori
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux