> -----Original Message----- > From: Paolo Bonzini [mailto:pbonzini@xxxxxxxxxx] > Sent: Tuesday, April 01, 2014 5:27 PM > To: Wu, Feng; gleb@xxxxxxxxxx; hpa@xxxxxxxxx; kvm@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v3 2/4] KVM: Add SMAP support when setting CR4 > > Il 01/04/2014 03:17, Wu, Feng ha scritto: > >>> A fault is considered > >>> > > + * as a SMAP violation if all of the following > >>> > > + * conditions are ture: > >>> > > + * - X86_CR4_SMAP is set in CR4 > >>> > > + * - An user page is accessed > >>> > > + * - Page fault in kernel mode > >>> > > + * - !(CPL<3 && X86_EFLAGS_AC is set) > >> > > >> > - if CPL < 3, EFLAGS.AC is clear > > Should it be "if CPL =3 or EFLAGS.AC is clear" ? > > > > What I meant is "if CPL < 3, EFLAGS.AC must also be clear", but your > version is fine too. You choose! Thanks for your comments! :) BTW: I tested nested today, this patch set works well for nested virtualization! > > Paolo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
