Il 20/03/2014 21:24, Alex Williamson ha scritto:
>
> +void kvm_ioapic_inject_all(struct kvm_ioapic *ioapic, unsigned long irr)
> +{
nit, kvm_ioapic_state.irr is a u32
Yes, but for_each_set_bit requires unsigned long.
> + u32 idx;
> +
> + rtc_irq_eoi_tracking_reset(ioapic);
> + for_each_set_bit(idx, &irr, 32) {
Can we use IOAPIC_NUM_PINS in place of 32?
Yes, indeeed.
> + printk("ioapic_service for GSI %d\n", idx);
Is this leftover debugging? Maybe give it a loglevel if it's
intentional. Looks reasonable otherwise. Thanks,
I'll remove it. Thanks for the review!
Paolo
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
