On Thu, 2011-12-22 at 12:21 +0200, Avi Kivity wrote: > On 12/22/2011 12:18 PM, Sasha Levin wrote: > > On Thu, 2011-12-22 at 12:03 +0200, Avi Kivity wrote: > > > On 12/08/2011 07:31 AM, Sasha Levin wrote: > > > > > > > > > > It sounds like Alex is considering KVM PPC's return value in this case (and > > > > > updating api.txt if appropriate) -- what say you on this patch? It actually > > > > > brings kvmtool's KVM_RUN return val check in line with QEMU's (also "< 0") and > > > > > nothing PPC will run without it, currently. (I'm about to repost a new series, > > > > > will include it for these reasons, until I hear more complaint ;) ) > > > > > > > > '<0' is fine as it's what api.txt says :) > > > > > > What? ioctls return -1 on error, not <0. > > > > <0 as opposed to the !=0 check we had there before. > > > > Theres no harm in checking for <0 even if the only possible negative > > result is -1. > > > > > > Yes, but the documentation should say -1. Which ioctl is this? That was KVM_RUN, but the documentation on that is correct (-1), so I'm not sure what I was thinking. On the other hand, there are several ioctls that do need fixing: - KVM_IOEVENTFD - KVM_PPC_GET_PVINFO - KVM_CAP_GET_TSC_KHZ -- Sasha. -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
