On Thu, 2011-12-22 at 12:03 +0200, Avi Kivity wrote: > On 12/08/2011 07:31 AM, Sasha Levin wrote: > > > > > > It sounds like Alex is considering KVM PPC's return value in this case (and > > > updating api.txt if appropriate) -- what say you on this patch? It actually > > > brings kvmtool's KVM_RUN return val check in line with QEMU's (also "< 0") and > > > nothing PPC will run without it, currently. (I'm about to repost a new series, > > > will include it for these reasons, until I hear more complaint ;) ) > > > > '<0' is fine as it's what api.txt says :) > > What? ioctls return -1 on error, not <0. <0 as opposed to the !=0 check we had there before. Theres no harm in checking for <0 even if the only possible negative result is -1. > > The syscalls do return <0, but libc converts that to -1/errno. > -- Sasha. -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
