Jes Sorensen wrote: > Zhang, Xiantao wrote: >> Jes Sorensen wrote: >>> Zhang, Xiantao wrote: >>>> Generally we should include linux/types.h instead of asm/types.h >>>> for kernel. We have already used the magic hack-module.awk(replace >>>> linux/types.h with asm/types.h) to make it work in userspace. :) >>>> Xiantao >>> Yes and no, in this case we don't need it, and there is no reason to >>> modify the kernel headers for KVM if we can share them unmodified. >> >> When you do "make sync" in userland, many files are modifed except >> this one. :) Xiantao > > I thought make sync had been removed :-) It at least no longer works. If make sync won't exist in future, you may only need to submit a patch for qemu-kvm.git to fix the header file directly, :-) Even with the patch you proposed, we still can't make kernel and userspace share all header files. For example, the header files under include/linux should be hacked also. Xiantao -- To unsubscribe from this list: send the line "unsubscribe kvm-ia64" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html