Avi Kivity wrote: > Zhang, Xiantao wrote: >>>> diff --git a/include/linux/kvm.h b/include/linux/kvm.h >>>> index 4269be1..9acf34a 100644 >>>> --- a/include/linux/kvm.h >>>> +++ b/include/linux/kvm.h >>>> @@ -383,7 +383,9 @@ struct kvm_trace_rec { >>>> #define KVM_CAP_MP_STATE 14 >>>> #define KVM_CAP_COALESCED_MMIO 15 >>>> #define KVM_CAP_SYNC_MMU 16 /* Changes to host mmap are reflected >>>> in guest */ +#ifdef CONFIG_X86 >>>> #define KVM_CAP_DEVICE_ASSIGNMENT 17 >>>> +#endif >>>> >>> I didn't see this changed to also accomodate IA64 in the patchset. >>> >> >> Since linux-ia64 DMAR is not ready in kvm.git, and it should be in >> linux-ia64.git. So it should be in kvm.git once Avi merged with >> upstream, so I didn't enable it for kvm/ia64 now. You know, S390 >> has no pci support, so if we put the code in kvm_mainc, we should >> use the macro to exclude other arch which doesn't need device >> assignments. If DMAR is ready for kvm.git, I will change this macro >> as following: #if defined(CONFIG_X86) || defined(CONFIG_IA64) >> #define KVM_CAP_DEVICE_ASSIGNMENT 17 >> #endif >> > > What does this mean? Does the patchset compile on top of kvm.git or > not? Hi, Avi This patchset can compile on kvm.git. But, you know, since DMAR support is only going into liux-ia64.git, and before you merging with linux-ia64.git, we can't enable it. In addition, we also need this macro to exclude some archs, for example, s390 can't use current device-assignment logic because it doesn't support pci. So, once you get merge with linux-ia64.git, we can define this macro for kvm/ia64. Thanks Xiantao -- To unsubscribe from this list: send the line "unsubscribe kvm-ia64" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html