On Tue, Sep 20, 2022 at 07:04:24PM +0100, Marc Zyngier wrote:
> Mark Brown <broonie@xxxxxxxxxx> wrote:
> > - switch (last->to_save) {
> > - case FP_STATE_TASK:
> > - break;
> > - case FP_STATE_FPSIMD:
> > - WARN_ON_ONCE(save_sve_regs);
> > - break;
> > - case FP_STATE_SVE:
> > - WARN_ON_ONCE(!save_sve_regs);
> > - break;
> > - }
> Given how short-lived this code is, consider dropping it altogether.
> Actually, the previous patch would make a lot more sense if it was
> merged with this one.
My thinking here is to introduce the state tracking and the
behaviour change separately to make it easier to unpick things if
anything goes wrong, it means that the behaviour change is in
clearly isolated patches separate to the more wide spread changes
to behaviour. The early patches make it more explicit what we
are currently doing, the later ones do new things.
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
