On Wed, May 4, 2022 at 7:17 AM Mark Brown <broonie@xxxxxxxxxx> wrote:
>
> On Mon, May 02, 2022 at 12:12:02PM -0700, Kalesh Singh wrote:
>
> > Recompile stack unwinding code for use with the nVHE hypervisor. This is
> > a preparatory patch that will allow reusing most of the kernel unwinding
> > logic in the nVHE hypervisor.
>
> > enum stack_type {
> > - STACK_TYPE_UNKNOWN,
> > +#ifndef __KVM_NVHE_HYPERVISOR__
> > STACK_TYPE_TASK,
> > STACK_TYPE_IRQ,
> > STACK_TYPE_OVERFLOW,
> > STACK_TYPE_SDEI_NORMAL,
> > STACK_TYPE_SDEI_CRITICAL,
> > +#endif /* !__KVM_NVHE_HYPERVISOR__ */
> > + STACK_TYPE_UNKNOWN,
> > __NR_STACK_TYPES
> > };
>
> I don't immediately see a problem with it but I'm curious as to why
> STACK_TYPE_UNKNOWN got moved to the end of the list here? It does mean
> that zeroed memory will default to STACK_TYPE_TASK but we're not
> actually relying on that. Otherwise
Hi Mark. Thanks for the reviews.
STACK_TYPE_UNKNOWN was moved to the end purely to group the common
enum values. Not a functionality change as we don't reply on an
uninitialized stack_type
Thanks,
Kalesh
>
> Reviwed-by: Mark Brown <broonie@xxxxxxxxxx>
>
> --
> To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@xxxxxxxxxxx.
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
