On Mon, May 02, 2022 at 12:12:02PM -0700, Kalesh Singh wrote: > Recompile stack unwinding code for use with the nVHE hypervisor. This is > a preparatory patch that will allow reusing most of the kernel unwinding > logic in the nVHE hypervisor. > enum stack_type { > - STACK_TYPE_UNKNOWN, > +#ifndef __KVM_NVHE_HYPERVISOR__ > STACK_TYPE_TASK, > STACK_TYPE_IRQ, > STACK_TYPE_OVERFLOW, > STACK_TYPE_SDEI_NORMAL, > STACK_TYPE_SDEI_CRITICAL, > +#endif /* !__KVM_NVHE_HYPERVISOR__ */ > + STACK_TYPE_UNKNOWN, > __NR_STACK_TYPES > }; I don't immediately see a problem with it but I'm curious as to why STACK_TYPE_UNKNOWN got moved to the end of the list here? It does mean that zeroed memory will default to STACK_TYPE_TASK but we're not actually relying on that. Otherwise Reviwed-by: Mark Brown <broonie@xxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/mailman/listinfo/kvmarm