Hi Marc, On Mon, Oct 11, 2021 at 1:15 AM Marc Zyngier <maz@xxxxxxxxxx> wrote: > > Hi Raghavendra, > > On Fri, 08 Oct 2021 00:34:27 +0100, > Raghavendra Rao Ananta <rananta@xxxxxxxxxx> wrote: > > > > Make use of the register read/write definitions from > > sysreg.h, instead of the existing definitions. A syntax > > correction is needed for the files that use write_sysreg() > > to make it compliant with the new (kernel's) syntax. > > > > Signed-off-by: Raghavendra Rao Ananta <rananta@xxxxxxxxxx> > > Reviewed-by: Oliver Upton <oupton@xxxxxxxxxx> > > Reviewed-by: Andrew Jones <drjones@xxxxxxxxxx> > > --- > > .../selftests/kvm/aarch64/debug-exceptions.c | 28 +++++++++---------- > > .../selftests/kvm/include/aarch64/processor.h | 13 +-------- > > 2 files changed, 15 insertions(+), 26 deletions(-) > > > > diff --git a/tools/testing/selftests/kvm/aarch64/debug-exceptions.c b/tools/testing/selftests/kvm/aarch64/debug-exceptions.c > > index e5e6c92b60da..11fd23e21cb4 100644 > > --- a/tools/testing/selftests/kvm/aarch64/debug-exceptions.c > > +++ b/tools/testing/selftests/kvm/aarch64/debug-exceptions.c > > @@ -34,16 +34,16 @@ static void reset_debug_state(void) > > { > > asm volatile("msr daifset, #8"); > > > > - write_sysreg(osdlr_el1, 0); > > - write_sysreg(oslar_el1, 0); > > + write_sysreg(0, osdlr_el1); > > + write_sysreg(0, oslar_el1); > > The previous patch has obviously introduced significant breakage which > this patch is now fixing. In the interval, the build is broken, which > isn't great. > > You can either rework this series to work around the issue, or I can > squash patches #2 and #3 together. Thanks. I didn't realize this. I'm fine with you squashing the patches together (I guess I would do the same). Regards, Raghavendra > > Thanks, > > M. > > -- > Without deviation from the norm, progress is not possible. _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/mailman/listinfo/kvmarm