Re: [PATCH] arm64: KVM: report configured SRE value to 32-bit world

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 17, 2016 at 11:55:21AM +0100, Vladimir Murzin wrote:
> On 17/08/16 11:46, Christoffer Dall wrote:
> > On Wed, Aug 10, 2016 at 10:49:43AM +0100, Vladimir Murzin wrote:
> >> After commit b34f2bc ("arm64: KVM: Make ICC_SRE_EL1 access return the
> >> configured SRE value") we report SRE value to 64-bit guest, but 32-bit
> >> one still handled as RAZ/WI what leads to funny promise we do not keep:
> >>
> >> "GICv3: GIC: unable to set SRE (disabled at EL2), panic ahead"
> >>
> >> We could keep that promise and force panic, but it doesn't look
> >> reliable, instead report configured SRE value to 32-bit guest.
> > 
> > I don't really understand this part of the commit message?
> > 
> > Why would we force a panic, and at what time?
> 
> To make statement "panic ahead" true ;) kind of irony, so feel free to
> remove that part (alternatively I can re-spin v2)
> 
No need, I just replaced it with:

  Instead, return the actual value of the ICC_SRE_EL1 register that the
  guest should see.

Thanks,
-Christoffer
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm



[Index of Archives]     [Linux KVM]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux