> -----Original Message----- > From: Wu, Feng > Sent: Tuesday, July 07, 2015 7:24 PM > To: Paolo Bonzini; Eric Auger; eric.auger@xxxxxx; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; kvmarm@xxxxxxxxxxxxxxxxxxxxx; > kvm@xxxxxxxxxxxxxxx; christoffer.dall@xxxxxxxxxx; marc.zyngier@xxxxxxx; > alex.williamson@xxxxxxxxxx; avi.kivity@xxxxxxxxx; mtosatti@xxxxxxxxxx; > joro@xxxxxxxxxx; b.reynal@xxxxxxxxxxxxxxxxxxxxxx > Cc: linux-kernel@xxxxxxxxxxxxxxx; patches@xxxxxxxxxx; Wu, Feng > Subject: RE: [RFC v2 3/6] irq: bypass: Extend skeleton for ARM forwarding > control > > > > > -----Original Message----- > > From: Paolo Bonzini [mailto:pbonzini@xxxxxxxxxx] > > Sent: Tuesday, July 07, 2015 7:22 PM > > To: Wu, Feng; Eric Auger; eric.auger@xxxxxx; > > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; kvmarm@xxxxxxxxxxxxxxxxxxxxx; > > kvm@xxxxxxxxxxxxxxx; christoffer.dall@xxxxxxxxxx; marc.zyngier@xxxxxxx; > > alex.williamson@xxxxxxxxxx; avi.kivity@xxxxxxxxx; mtosatti@xxxxxxxxxx; > > joro@xxxxxxxxxx; b.reynal@xxxxxxxxxxxxxxxxxxxxxx > > Cc: linux-kernel@xxxxxxxxxxxxxxx; patches@xxxxxxxxxx > > Subject: Re: [RFC v2 3/6] irq: bypass: Extend skeleton for ARM forwarding > > control > > > > > > > > On 07/07/2015 13:18, Wu, Feng wrote: > > > Then I still need assign prod and de-assign prod in > > > irq_bypass_register_consumer/irq_bypass_unregister_consumer, Right? > > > Would you please share why this is better. > > > > The need to store the consumer->producer link seems to be unique to > > posted interrupts. It is difficult to say without seeing the PI code, > > but I prefer to keep the bypass manager as small as possible. > > Fine. I will follow your suggestion! If using the following changes, how can we assign 'prod', we need to use container_of to get struct kvm_kernel_irqfd and then refer to 'prod', but we cannot do this in irq_bypass_register_consumer(), right? It is a common API. But we can only get the associated producer info inside bypass manager, right? Thanks, Feng struct kvm_kernel_irqfd { ...... struct irq_bypass_consumer cons; struct irq_bypass_producer *prod; }; > > Thanks, > Feng > > > > > Paolo _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
